lkml.org 
[lkml]   [2015]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH 1/1] Remove unneeded "0x" when %pa formatting is used.
From
On Mon, Nov 30, 2015 at 10:33 PM, Dmitry Krivenok
<krivenok.dmitry@gmail.com> wrote:
>>> if (size > max_size) {
>>> dev_err(pcie->dev,
>>> - "res size 0x%pap exceeds max supported size 0x%llx\n",
>>> + "res size %pap exceeds max supported size 0x%llx\n",
>>
>> %pa also works.
>>
>
> Yes, but AFAIK %pap and %pa are identical (see address_val() in lib/vsprintf.c),
> so I'm not sure I understand your comment.
>
> Did you mean that %pa should be used instead of %pap?
> I see that %pa is used much more often than %pap, but I didn't find any
> evidence that %pap is deprecated.

+Rasmus.

No, it's not, but it explicitly for phys_addr_t (it might be nice to
to have %par, for example for explicitly shown that is for
resource_size_t, Rasmus?).

For my opinion for resources better to use %pa for now, though %pap
will work as well.

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2015-12-13 02:21    [W:0.039 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site