lkml.org 
[lkml]   [2015]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] usb: host: ehci-sched: silence checkpatch warning
From
2015-12-11 22:50 GMT-03:00 Geyslan G. Bem <geyslan@gmail.com>:
> This patch moves comment into the else branch avoiding the following
> misleading warning.
>
> "braces {} are not necessary for single statement blocks"
>
> Caught by checkpatch.
>
> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
> Suggested-by: Joe Perches <joe@perches.com>
> ---
> drivers/usb/host/ehci-sched.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-sched.c b/drivers/usb/host/ehci-sched.c
> index f6e828a..b2af0b3 100644
> --- a/drivers/usb/host/ehci-sched.c
> +++ b/drivers/usb/host/ehci-sched.c
> @@ -1560,13 +1560,10 @@ iso_stream_schedule(
> (stream->ps.bw_period - 1);
> stream->ps.phase_uf = start & 7;
> reserve_release_iso_bandwidth(ehci, stream, 1);
> - }
> -
> - /* New stream is already scheduled; use the upcoming slot */
> - else {
> + } else {
> + /* New stream is already scheduled; use the upcoming slot */
> start = (stream->ps.phase << 3) + stream->ps.phase_uf;
> }
> -
> stream->next_uframe = start;
> new_stream = true;
> }
> --
> 2.6.3
>

This one must be applied only after the bunch [PATCH 00/10] usb: host:
ehci-sched: cleanup
https://lkml.org/lkml/2015/12/11/940


--
Regards,

Geyslan G. Bem
hackingbits.com


\
 
 \ /
  Last update: 2015-12-12 03:21    [W:0.049 / U:0.108 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site