Messages in this thread | | | Date | Fri, 11 Dec 2015 23:20:28 +0200 | Subject | Re: [PATCH v3 2/8] lib: add "on" and "off" to strtobool | From | Andy Shevchenko <> |
| |
On Fri, Dec 11, 2015 at 8:50 PM, Kees Cook <keescook@chromium.org> wrote: > On Fri, Dec 11, 2015 at 9:00 AM, Andy Shevchenko > <andy.shevchenko@gmail.com> wrote: >> On Wed, Dec 9, 2015 at 11:43 PM, Kees Cook <keescook@chromium.org> wrote: >>> Several places in the kernel expect to use "on" and "off" for their >>> boolean signifiers, so add them to strtobool.
>>> + if (!s) >>> + return -EINVAL; >>> + >> >> This change I think is better to do separately. Do we have even need for it? > > I'm happy to separate it, sure. I added it here because several of the > __setup and param callers do a check for !NULL input, and it made this > cleaner. Also it seems sensible to do this check anyway.
OK.
>>> + default: >>> + return -EINVAL; >>> + } >>> + break; >>> default: >>> return -EINVAL; >> >> Maybe in both cases >> default: >> break; >> } >> … >> } >> return -EINVAL; > > I went back and forth on this. To switch to the fall-back being EINVAL > meant I had to change all the other "breaks" into "return 0", and it > just looked ugly to me. If that is preferred, though, I'm happy to do > it.
I have no strong feelings about that, I prefer whatever looks neater.
-- With Best Regards, Andy Shevchenko
| |