Messages in this thread | | | From | David Eccher <> | Date | Fri, 11 Dec 2015 22:12:31 +0100 | Subject | Re: [PATCH 1/1] USB: inode.c: fix unbalanced spin_lock in ep0_write |
| |
On Fri, Dec 11, 2015 at 9:11 PM, Al Viro <viro@zeniv.linux.org.uk> wrote: > > On Fri, Dec 11, 2015 at 08:56:26PM +0100, David Eccher wrote: > > Fix bad unlock balance: ep0_write enter with the locks locked from inode.c:1769, > > hence it must exit with spinlock held to avoid double unlock in dev_config. > > *Ugh* > > Just take that spinlock before the if (retval < 0) and don't drop it after > clear_req(), then...
Oh, yeah good point, I'll send a v2...and test the patch thru checkpatch.pl, sorry
-- David Eccher
| |