Messages in this thread | | | Date | Fri, 11 Dec 2015 17:55:13 -0300 | Subject | Re: [PATCH v3 4/9] usb: host: ehci.h: fix single statement macros | From | "Geyslan G. Bem" <> |
| |
2015-12-11 13:30 GMT-03:00 Greg Kroah-Hartman <gregkh@linuxfoundation.org>: > On Thu, Dec 10, 2015 at 03:18:19PM -0300, Geyslan G. Bem wrote: >> Don't use the 'do {} while (0)' wrapper in a single statement macro. >> >> Caught by checkpatch: "WARNING: Single statement macros should not >> use a do {} while (0) loop" >> >> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com> >> --- >> Change in v3: >> - There's no need to evaluate COUNT(x) in #ifdef EHCI_STATS >> false branch. Thus an empty #define is the choice. > > Odd numbering scheme of patches, I can't figure this out... Greg,
I sent new versions only to modified ones. 9 is v1. 4 is v3. rest is v2.
Next time I'll send new versions for all.
> > Can you resend this whole series so I know I got it all correct? I hope so. :-) Messing around with branches and merges here. I tell you soon.
> > thanks, > > greg k-h
-- Regards,
Geyslan G. Bem hackingbits.com
| |