lkml.org 
[lkml]   [2015]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH 2/2] z2ram: Delete a jump label in z2_init()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 11 Dec 2015 18:48:14 +0100

    This issue was detected by using the Coccinelle software.

    * Let us return directly if a call of the function "register_blkdev" failed.

    * Remove the jump label "err" then.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/block/z2ram.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
    index 968f9e5..b07581d 100644
    --- a/drivers/block/z2ram.c
    +++ b/drivers/block/z2ram.c
    @@ -345,9 +345,8 @@ z2_init(void)
    if (!MACH_IS_AMIGA)
    return -ENODEV;

    - ret = -EBUSY;
    if (register_blkdev(Z2RAM_MAJOR, DEVICE_NAME))
    - goto err;
    + return -EBUSY;

    ret = -ENOMEM;
    z2ram_gendisk = alloc_disk(1);
    @@ -374,7 +373,6 @@ out_queue:
    put_disk(z2ram_gendisk);
    out_disk:
    unregister_blkdev(Z2RAM_MAJOR, DEVICE_NAME);
    -err:
    return ret;
    }

    --
    2.6.3


    \
     
     \ /
      Last update: 2015-12-11 19:41    [W:4.013 / U:0.560 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site