lkml.org 
[lkml]   [2015]   [Dec]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V6 20/26] perf: changing pmu::setup_aux() parameter to include event
Date
Mathieu Poirier <mathieu.poirier@linaro.org> writes:

> For Coresight ETMv3/4 tracers the event carries information
> about trace modes such as user or kernel space tracing and
> whether tracing is allowed when operating in secure mode.

Ok, so it looks to me that what you're doing in your setup_aux with the
event, you should rather be doing in pmu::event_init(), which takes
event as a parameter and it even makes more sense semantically, because
that bit is really configuring the parameters of tracing and not
capturing, which setup_aux() is more about. And the above paragraph also
sounds very much like it. Since in Coresight there is a very clear
distinction between trace generation (sources) and capturing (sinks) it
should also be possible to structure the code in such a way that the
former are not as closely tied to the latter. Please correct me if I'm
missing something.

Regards,
--
Alex


\
 
 \ /
  Last update: 2015-12-11 15:41    [W:0.155 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site