This message generated a parse failure. Raw output follows here. Please use 'back' to navigate. From devnull@lkml.org Sun May 19 00:54:58 2024 >From spaans Fri Dec 11 08:48:03 2015 Received: from pop.ziggo.nl [212.54.42.19] by squeeze.vs19.net with POP3 (fetchmail-6.3.21) for (single-drop); Fri, 11 Dec 2015 08:48:03 +0100 (CET) Received: from md5.tb.mail.iss.local ([212.54.34.103]) by mc8.tb.mail.iss.local (Dovecot) with LMTP id XzwFGtF7alZNNQAALmT+sg for ; Fri, 11 Dec 2015 08:33:38 +0100 Received: from mx14.mnd.mail.iss.as9143.net ([212.54.34.103]) by md5.tb.mail.iss.local (Dovecot) with LMTP id +EbKFYziBFakFgAA7jSZHA ; Fri, 11 Dec 2015 08:41:58 +0100 Received: from vger.kernel.org ([209.132.180.67]) by mx14.mnd.mail.iss.as9143.net with esmtp (Exim 4.82) (envelope-from ) id 1a7ICw-0002lh-6a for bmw12-lkml@ziggo.nl; Fri, 11 Dec 2015 08:33:38 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753249AbbLKHd1 (ORCPT ); Fri, 11 Dec 2015 02:33:27 -0500 Received: from mail-bn1bon0132.outbound.protection.outlook.com ([157.56.111.132]:33760 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1753079AbbLKHdX (ORCPT ); F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=selector1; h=From:To:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=6I5e83wvbyyxtlwOT3ThX36pdHpP6w19YHnbpk/k6ic=; b=AGPgUrDXT7m6biW4SJYCy1ipfCSHMs8uZNE6yuf7ZR+DJU0ul//sJbwUdiSmSyxO+chu184m2R Received: from BN3PR0301CA0009.namprd03.prod.outlook.com (10.160.180.147) by CY1PR0301MB0731.namprd03.prod.outlook.com (10.160.159.149) with Microsoft SMTP Server (TLS) id 15.1.355.16; Fri, 11 Dec 2015 07:33:20 +0000 Received: from BL2FFO11OLC001.protection.gbl (2a01:111:f400:7c09::176) by BN3PR0301CA0009.outlook.office365.com (2a01:111:e400:4000::19) with Microsoft SMTP Server (TLS) id 15.1.355.16 via Frontend Transport; Fri, 11 Dec 2015 07:33:19 +0000 Authentication-Results: spf=pass (sender IP is 23.103.249.84) smtp.mailfrom=microsoft.com; linuxfoundation.org; dkim=none (message not signed) header.d=none;linuxfoundation.org; dmarc=pass action=none header.from=microsoft.com; Received-SPF: Pass (protection.outlook.com: domain of microsoft.com designates 23.103.249.84 as permitted sender) receiver=protection.outlook.com; client-ip=23.103.249.84; helo=064-smtp-out.microsoft.com; Received: from 064-smtp-out.microsoft.com (23.103.249.84) by BL2FFO11OLC001.mail.protection.outlook.com (10.173.161.185) with Microsoft SMTP Server (TLS) id 15.1.346.13 via Frontend Transport; Fri, 11 Dec 2015 07:33:19 +0000 Received: from HKXPR3004MB0088.064d.mgd.msft.net (141.251.197.88) by HKXPR3004MB0085.064d.mgd.msft.net (141.251.197.85) with Microsoft SMTP Server (TLS) id 15.1.361.8; Fri, 11 Dec 2015 07:33:11 +0000 Received: from HKXPR3004MB0088.064d.mgd.msft.net ([141.251.197.88]) by HKXPR3004MB0088.064d.mgd.msft.net ([141.251.197.88]) with mapi id 15.01.0355.012; Fri, 11 Dec 2015 07:33:11 +0000 From: Dexuan Cui To: KY Srinivasan , "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "devel@linuxdriverproject.org" , "olaf@aepfle.de" , Subject: RE: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always in interrupt context Thread-Topic: [PATCH V2 02/10] Drivers: hv: utils: run polling callback always in interrupt context Thread-Index: AQHREqN/B3uPQ5hvd0CAAnuI1+1NHp7EObOggADkeACAAIKOgA== Date: Fri, 11 Dec 2015 07:33:11 +0000 Message-Id: <02dd0f8d7f8e4cacb9e54a067fd483e4@HKXPR3004MB0088.064d.mgd.msft.net> References: <1446167538-19409-1-git-send-email-kys@microsoft.com> <1446167566-19448-1-git-send-email-kys@microsoft.com> <1446167566-19448-2-git-send-email-kys@microsoft.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: yes X-MS-TNEF-Correlator: X-Originating-IP: [141.251.57.196] Content-Type: multipart/mixed; boundary="_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_" Mime-Version: 1.0 X-EOPAttributedMessage: 0 X-Microsoft-Exchange-Diagnostics: 1;BL2FFO11OLC001;1:NHDnIB19DWlSk2mg5KirB2NGaJo3Mkxtu4Qlq8BPEbDOWdqrJFwfRFNICR9Q+3OWQByUAk2UxjLsmlbcgJ4aXAtF0qLgNeaso9nlnCNsZbkeGYA2xLXnHItuZ6eLyp77UNpZxOihgy+uIUhyfwT8ulfHnVe4dj8gmjR9B9nQvqk7sFwmO2tpFCTqrGJwpaNjyGozk6EO8LaY64JT82A3pg8Z7YkAZwniDjI2j6LnO1g X-Forefront-Antispam-Report: CIP:23.103.249.84;CTRY:;IPV:NLI;EFV:NLI;SFV:NSPM;SFS:(10019020)(6009001)(2980300002)(438002)(13464003)(164054003)(189002)(199003)(551934003)(2201001)(92566002)(2476003)(568964002)(76176999)(15975445007)(5005710100001)(300700001)(5003600100002)(189998001) X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0731;2:bWb8ZAT5Fn9fVztitiVH24ZmnK+z1rkbE9IQ22vEpNSEuzoPPSEWYYngne3bEMnE8and7Ne3t2o4nr6JrDLbhyFqk4FM7bYHmWesRVqWoS3zcwJfUoWFijdyJedR2KYuFD+1P2Bv4f4asBcUDl8btw==;3:fwB3b+EXAfIRH44j0imyuyd2B5WxxoKD9xVLjQkyHDoeASBgXxXKlxLWF3DHg1S9Nm6v1qWuX/6g1FT X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501001);SRVR:CY1PR0301MB0731; X-O365EOP-Header: O365_EOP: Allow for Unauthenticated Relay X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0731;20:URvT83VJhYBvuKjsh+aFjQ5APdle9ha9miNCtw7gT1rF+vpTPRI4NK65Hni3qhaTHlVzCu1zjU2dq0jLWntDOHBlBWAHme9DKFX8k+V4CLTfDY4L1i6l/ZppMQJzzw3l5GQLOtfsTqezwDYBpBf4+yc7PSWjEUsA9MEwrPO8/651UXGovRld2L2mjNkfYG8bM/+rSuxKpB4IEnh8ibgELgwRTZx5ui1T64JHgPo6R X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(61425038)(601004)(2401047)(520078)(8121501046)(5005006)(10201501046)(3002001)(61426038)(61427038);SRVR:CY1PR0301MB0731;BCL:0;PCL:0;RULEID:;SRVR:CY1PR0301MB0731; X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0731;4:i+6oJ+DJaa85Bf7s7cNSUoOht5lHm5Cx0iajZ3np5H0em9r/+FALWiVSieNRq59GwzCdRRJmLU0dxhVxACML+by/qvY/j2Fd57A/qpKeheqEyaezeMN6NL8UQSRyb5h1iiER3ri+uzUKBozM4Kp44nuIA3m69oEd4tLeKRnVr4JR1igerfvWm7C6/dI9PlhSy6q8G7ZcBn0ZS7e0p/F5oqy6HUHldmsKM/FW+R9IgI X-Forefront-PRVS: 0787459938 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;CY1PR0301MB0731;23:fk9ZLS7+IkC2DChn9ACI9jUPhNhKoxqDteYcV+I?= =?us-ascii?Q?JVqFe4FTB7DzRPz18zegL4qVXyBoLit8LunV0gqtzqgKZyo/yrFNFOuNA1V8?= =?us-ascii?Q?6P6p6kY9xd6aUNWB/Sinzj2XzjOKadT9xfJpp1KlthFqm7jXjS7Cl1G9Wpax?= =?us-ascii?Q?ijRT+leYSAxUu X-Microsoft-Exchange-Diagnostics: 1;CY1PR0301MB0731;5:PRMM8rNf1agdUNUXioeycrjv8447gSO1eSNUG3+X4MOuDQPfeK6DX5t3UfyfGKiiQJd74Jccwng/ootfq8blU6o+gRIlWjs1bh/81OKmtRRP3RwQgTdJYEgQwv/YsI+9FYGR0AlLERxnaCchzS0IbQ==;24:pDDdbmyQse7INHD6Uu71WfqPgShDHrcunDOewgmRizVxFm+/2QXW7zJJEJM4Thy0UhC8x7B+F80xG5 SpamDiagnosticOutput: 1:23 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: microsoft.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Dec 2015 07:33:19.2815 (UTC) X-MS-Exchange-CrossTenant-Id: 72f988bf-86f1-41af-91ab-2d7cd011db47 X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=72f988bf-86f1-41af-91ab-2d7cd011db47;Ip=[23.103.249.84];Helo=[064-smtp-out.microsoft.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY1PR0301MB0731 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-Id: X-Mailing-List: linux-kernel@vger.kernel.org X-Ziggo-spamsetting: Instelling=Gemiddeld Scorelimiet=14 X-Ziggo-spambar: / X-Ziggo-spamscore: 0.0 X-Ziggo-spamreport: CMAE Analysis: v=2.1 cv=YM1iskyx c=1 sm=0 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:17 a=yMhMjlubAAAA:8 a=6V0prl30AAAA:8 a=VwQbUJbxAAAA:8 a=cIF5Tx0qAAAA:8 a=UqCG9HQmAAAA:8 a=IVvqCPU2AAAA:8 a=C5pystEJat8A:10 a=fo6bvj6EYYwA:10 a=wUQvQvOEmiQA:10 a=D19gQVrFAAAA:8 a=Lh X-Ziggo-Spam-Status: No X-Spam-Status: No X-Spam-Flag: No --_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_ Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable > -----Original Message----- > From: KY Srinivasan > Sent: Friday, December 11, 2015 7:23 > > It looks the patch has not been Greg's tree yet. > > > > I have 2 questions about the patch: > > > > 1. hv_poll_channel() is invoked in fcopy_handle_handshake(), but not in > > vss_handle_handshake() and kvp_handle_handshake(). > > Why -- I guess we missed the vss/kvp cases somehow? > I will fix this. Thanks, KY! BTW, I fixed another small issue by https://lkml.org/lkml/2015/12/10/50 (The mail is attached for your convenience) > > 2. With the patch, hv_fcopy_onchannelcallback() can be invoked in the > > tasklet (i.e., vmbus_on_event(). NB: local irq is enabled), and in the > > hard irq handler(the IPI handler, e.g., > > fcopy_poll_wrapper() -> fcopy_poll_wrapper()). > > > > Can the former be interrupted by the latter? > > e.g., when the callback is running in the tasklet on vCPU0, > > fcopy_timeout_func() or fcopy_on_msg() could send the IPI to > > vCPU0 from another vCPU. >=20 > Keep in mind that when the poll function is run, the state will not be > HVUTIL_READY. The state will be set to HVUTIL_READY in the IPI > handler. So, it is ok if the tasklet is interrupted by the IPI handler. >=20 > K. Y Got it. BTW, in fcopy_handle_handshake(), IMO the line fcopy_transaction.state =3D HVUTIL_READY; just before=20 hv_poll_channel(fcopy_transaction.recv_channel, fcopy_poll_wrapper); should be removed? Because in fcopy_poll_wrapper() we always have the same line.=20 Ditto for kvp/vss. Thanks, -- Dexuan --_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_ Content-Type: message/rfc822 Content-Disposition: attachment; creation-date="Fri, 11 Dec 2015 07:33:09 GMT"; modification-date="Fri, 11 Dec 2015 07:33:09 GMT" Received: from HKXPR3004MB0087.064d.mgd.msft.net (141.251.197.87) by HKXPR3004MB0088.064d.mgd.msft.net (141.251.197.88) with Microsoft SMTP Server (TLS) id 15.1.355.11 via Mailbox Transport; Thu, 10 Dec 2015 07:39:05 +0000 Received: from DB3PR30CA004.064d.mgd.msft.net (141.251.50.14) by HKXPR3004MB0087.064d.mgd.msft.net (141.251.197.87) with Microsoft SMTP Server (TLS) id 15.1.355.11; Thu, 10 Dec 2015 07:39:04 +0000 Received: from na01-bn1-obe.outbound.protection.outlook.com (207.46.163.182) by cloudmail.microsoft.com (141.251.50.14) with Microsoft SMTP Server (TLS) id 15.1.337.9 via Frontend Transport; Thu, 10 Dec 2015 07:39:03 +0000 Received: from BY2PR03CA011.namprd03.prod.outlook.com (10.255.93.28) by BY2PR0301MB1975.namprd03.prod.outlook.com (10.163.196.21) with Microsoft SMTP Server (TLS) id 15.1.337.19; Thu, 10 Dec 2015 07:39:01 +0000 Received: from BN1BFFO11FD047.protection.gbl (10.255.93.4) by BY2PR03CA011.outlook.office365.com (10.255.93.28) with Microsoft SMTP Server (TLS) id 15.1.355.16 via Frontend Transport; Thu, 10 Dec 2015 07:39:01 +0000 Received: from whitealder.osuosl.org (140.211.166.138) by BN1BFFO11FD047.mail.protection.outlook.com (10.58.145.2) with Microsoft SMTP Server id 15.1.337.8 via Frontend Transport; Thu, 10 Dec 2015 07:39:01 +0000 Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 498609264D; Thu, 10 Dec 2015 07:39:00 +0000 (UTC) Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2c+Yjqrln4vK; Thu, 10 Dec 2015 07:38:59 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by whitealder.osuosl.org (Postfix) with ESMTP id 9C88792647; Thu, 10 Dec 2015 07:38:57 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 9B8731C0FE5 for ; Thu, 10 Dec 2015 07:38:56 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 9882F958D3 for ; Thu, 10 Dec 2015 07:38:56 +0000 (UTC) Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id NU4ZVczs+SGN for ; Thu, 10 Dec 2015 07:38:54 +0000 (UTC) Received: from p3plsmtps2ded03.prod.phx3.secureserver.net (p3plsmtps2ded03.prod.phx3.secureserver.net [208.109.80.60]) by hemlock.osuosl.org (Postfix) with ESMTPS id D1D4A958BF for ; Thu, 10 Dec 2015 07:38:54 +0000 (UTC) Received: from linuxonhyperv.com ([72.167.245.219]) by : HOSTING RELAY : with SMTP id 6vdZaNqG7sHQS6vdZaqHc6; Thu, 10 Dec 2015 00:27:38 -0700 Received: by linuxonhyperv.com (Postfix, from userid 518) id 830121904CF; Thu, 10 Dec 2015 01:00:57 -0800 (PST) From: Dexuan Cui To: "gregkh@linuxfoundation.org" , "linux-kernel@vger.kernel.org" , "driverdev-devel@linuxdriverproject.org" , "olaf@aepfle.de" , "apw@canonical.com" , "jasowang@redhat.com" , KY Srinivasan , "vkuznets@redhat.com" CC: Haiyang Zhang Subject: [PATCH] tools: hv: vss: fix the write()'s argument: error -> vss_msg Thread-Topic: [PATCH] tools: hv: vss: fix the write()'s argument: error -> vss_msg Thread-Index: AQHRMx3Y8Kqb5/Wn20GjlJ0CCapg2g== Sender: devel Date: Thu, 10 Dec 2015 09:00:57 +0000 Message-ID: <1449738057-4596-1-git-send-email-decui@microsoft.com> List-Help: List-Subscribe: , List-Unsubscribe: , Content-Language: en-US X-MS-Exchange-Organization-AuthSource: BN1BFFO11FD047.protection.gbl X-MS-Has-Attach: X-Auto-Response-Suppress: All X-MS-Exchange-Organization-Network-Message-Id: bb0285ab-c675-4033-6e69-08d30134fa7d X-Message-Flag: Follow up X-MS-TNEF-Correlator: x-originating-ip: 72.167.245.219 received-spf: None (protection.outlook.com: linuxdriverproject.org does not designate permitted sender hosts) x-organizationheaderspreserved: BY2PR0301MB1975.namprd03.prod.outlook.com x-crosspremisesheaderspromoted: DB3PR30CA004.064d.mgd.msft.net x-forefront-antispam-report: CIP:140.211.166.138;CTRY:US;IPV:NLI;EFV:NLI;SFV:SKS;SFS:;DIR:INB;SFP:;SCL:9;SRVR:BY2PR0301MB1975;H:whitealder.osuosl.org;FPR:;SPF:None;LANG:en; x-originatororg: microsoft.onmicrosoft.com x-crosspremisesheadersfiltered: DB3PR30CA004.064d.mgd.msft.net authentication-results: spf=none (sender IP is 140.211.166.138) smtp.mailfrom=linuxdriverproject.org; microsoft.com; dkim=none (message not signed) header.d=none;microsoft.com; dmarc=fail action=none header.from=microsoft.com; Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 I found this by chance. I don't have a specific bug caused by this. Cc: Vitaly Kuznetsov Cc: "K. Y. Srinivasan" Signed-off-by: Dexuan Cui Cc: stable@vger.kernel.org --- tools/hv/hv_vss_daemon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c index 96234b6..5d51d6f 100644 --- a/tools/hv/hv_vss_daemon.c +++ b/tools/hv/hv_vss_daemon.c @@ -254,7 +254,7 @@ int main(int argc, char *argv[]) syslog(LOG_ERR, "Illegal op:%d\n", op); } vss_msg->error =3D error; - len =3D write(vss_fd, &error, sizeof(struct hv_vss_msg)); + len =3D write(vss_fd, vss_msg, sizeof(struct hv_vss_msg)); if (len !=3D sizeof(struct hv_vss_msg)) { syslog(LOG_ERR, "write failed; error: %d %s", errno= , strerror(errno)); -- 1.9.1 _______________________________________________ devel mailing list devel@linuxdriverproject.org https://na01.safelinks.protection.outlook.com/?url=3Dhttp%3a%2f%2fdriverdev= .linuxdriverproject.org%2fmailman%2flistinfo%2fdriverdev-devel&data=3D01%7c= 01%7cdecui%40064d.mgd.microsoft.com%7c6038ce2d24784746fa0408d30134f8d9%7c72= f988bf86f141af91ab2d7cd011db47%7c1&sdata=3D6Hs1UNlA11wBtnU5XvHhpCgkUlIhWVMK= xPHVj9UAZq8%3d --_002_02dd0f8d7f8e4cacb9e54a067fd483e4HKXPR3004MB0088064dmgdm_-- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/