Messages in this thread | ![/](/images/icornerl.gif) | | Date | Fri, 11 Dec 2015 11:23:40 +0800 | From | Herbert Xu <> | Subject | Re: [PATCH v4 5/5] crypto: AES CBC multi-buffer glue code |
| |
On Thu, Dec 10, 2015 at 08:39:45AM -0800, Tim Chen wrote: > > The inner cipher is called synchronously from the outer layer > async cipher algorithm in cbc_mb_async_ablk_decrypt via > > err = crypto_blkcipher_crt(child_tfm)->decrypt( > &rctx->desc, req->dst, req->src, req->nbytes);
We should avoid bypassing the API and directly calling crypto driver functions like this.
What if you made it a proper ablkcipher and just called it through the API?
Thanks, -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
| ![\](/images/icornerr.gif) |