Messages in this thread | | | Date | Thu, 10 Dec 2015 09:01:18 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCHSET 00/16] perf top: Add multi-thread support (v1) |
| |
* Namhyung Kim <namhyung@kernel.org> wrote:
> Hello, > > This patchset if an attempt to support multi-threading in perf top. > In fact, perf top already run on two threads - a worker thread and a > display thread. However processing all samples with a single thread > in a large machine can have scalability problems. > > This patchset extends it to have multiple worker threads to process > samples concurrently. Users can control the number of threads using > --num-thread option. And there's a collector thread for passing hist > entries from worker threads to the display thread.
Could you please make the number of threads default to the number of CPUs?
Since perf top is doing one perf event per CPU anyway, that's a pretty natural model.
( I think 'perf record' should use per CPU threads as well to receive events, to address the 'IO overload' problems with -g recording on larger CPU counts. )
Thanks,
Ingo
| |