Messages in this thread | | | Date | Thu, 10 Dec 2015 10:57:23 -0500 (EST) | From | Alan Stern <> | Subject | Re: [PATCH 6/9v2] usb: host: ehci.h: use space after comma |
| |
On Thu, 10 Dec 2015, Peter Senna Tschudin wrote:
> > /* next async queue entry, or pointer to interrupt/periodic QH */ > > -#define QH_NEXT(ehci,dma) (cpu_to_hc32(ehci, (((u32)dma)&~0x01f)|Q_TYPE_QH)) > > +#define QH_NEXT(ehci, dma) \ > > + (cpu_to_hc32(ehci, (((u32) dma) & ~0x01f) | Q_TYPE_QH)) > > For the maintainers: Is having two lines here better than having a line with 83 chars?
Two lines is better. This patch is fine and so are the other 7 -- I never received 9/9v2 (the original 9/9 was okay).
Alan Stern
| |