lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH 4/9v2] usb: host: ehci.h: fix single statement macros
    From
    2015-12-10 8:54 GMT-03:00 Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>:
    > Hello.
    >
    > On 12/10/2015 1:32 AM, Geyslan G. Bem wrote:
    >
    >> Don't use the 'do {} while (0)' wrapper in a single statement macro.
    >>
    >> Caught by checkpatch: "WARNING: Single statement macros should not
    >> use a do {} while (0) loop"
    >>
    >> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
    >> ---
    >> drivers/usb/host/ehci.h | 4 ++--
    >> 1 file changed, 2 insertions(+), 2 deletions(-)
    >>
    >> diff --git a/drivers/usb/host/ehci.h b/drivers/usb/host/ehci.h
    >> index cfeebd8..945000a 100644
    >> --- a/drivers/usb/host/ehci.h
    >> +++ b/drivers/usb/host/ehci.h
    >> @@ -244,9 +244,9 @@ struct ehci_hcd { /* one per
    >> controller */
    >> /* irq statistics */
    >> #ifdef EHCI_STATS
    >> struct ehci_stats stats;
    >> -# define COUNT(x) do { (x)++; } while (0)
    >> +# define COUNT(x) ((x)++)
    >> #else
    >> -# define COUNT(x) do {} while (0)
    >> +# define COUNT(x) ((void) 0)
    >
    >
    > Why not just empty #define?

    Indeed. I'll change it.
    Tks Sergei.


    >
    > [...]
    >
    > MBR, Sergei
    >



    --
    Regards,

    Geyslan G. Bem
    hackingbits.com


    \
     
     \ /
      Last update: 2015-12-10 13:41    [W:6.890 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site