lkml.org 
[lkml]   [2015]   [Dec]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] usb: remove redundant conditions
From
2015-12-10 7:44 GMT-03:00 Johan Hovold <johan@kernel.org>:
> On Wed, Dec 09, 2015 at 10:52:42PM -0300, Geyslan G. Bem wrote:
>> This patch removes redundant conditions.
>>
>> - (!A || (A && B)) is the same as (!A || B).
>> - (length && length > 5) can be reduced to a single evaluation.
>>
>> Caught by: cppcheck
>>
>> Signed-off-by: Geyslan G. Bem <geyslan@gmail.com>
>> ---
>> drivers/usb/gadget/udc/s3c-hsudc.c | 2 +-
>> drivers/usb/host/fhci-sched.c | 2 +-
>> drivers/usb/musb/musb_gadget.c | 5 ++---
>> drivers/usb/serial/io_edgeport.c | 35 ++++++++++++++---------------------
>> drivers/usb/serial/mos7840.c | 2 +-
>> 5 files changed, 19 insertions(+), 27 deletions(-)
>
> Please split out (at least) the usb-serial changes into two patches.
Ok, I'll send v2 later.

>
> Johan



--
Regards,

Geyslan G. Bem
hackingbits.com


\
 
 \ /
  Last update: 2015-12-10 12:01    [W:0.098 / U:0.100 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site