Messages in this thread | | | Date | Tue, 01 Dec 2015 16:28:10 -0500 (EST) | Subject | Re: [v8, 2/6] fsl/fman: Add FMan support | From | David Miller <> |
| |
From: <igal.liberman@freescale.com> Date: Mon, 30 Nov 2015 14:20:58 +0200
> +typedef irqreturn_t (fman_exceptions_cb)(struct fman *fman, > + enum fman_exceptions exception);
Function and function pointer declarations and definitions should be indented such that the second and subsequent lines begin precisely at the first column after the openning parenthesis of the first line.
Please audit this and fix it in your entire submission, almost ever new such case is done incorrectly.
> + fman->state->exceptions = (EX_DMA_BUS_ERROR | > + EX_DMA_READ_ECC | > + EX_DMA_SYSTEM_WRITE_ECC | > + EX_DMA_FM_WRITE_ECC | > + EX_FPM_STALL_ON_TASKS | > + EX_FPM_SINGLE_ECC | > + EX_FPM_DOUBLE_ECC | > + EX_QMI_DEQ_FROM_UNKNOWN_PORTID | > + EX_BMI_LIST_RAM_ECC | > + EX_BMI_STORAGE_PROFILE_ECC | > + EX_BMI_STATISTICS_RAM_ECC | > + EX_MURAM_ECC | > + EX_BMI_DISPATCH_RAM_ECC | > + EX_QMI_DOUBLE_ECC | > + EX_QMI_SINGLE_ECC);
The same applies to multi-line parenthesized expressions like this one. Again, please audit and fix this in your entire submission.
Thanks.
| |