Messages in this thread | | | Subject | Re: [PATCH 2/4] gcov: use within_module() helper. | From | Peter Oberparleiter <> | Date | Mon, 9 Nov 2015 09:19:43 +0100 |
| |
On 09.11.2015 05:23, Rusty Russell wrote: > An exact mapping would be within_module_core(), but at this stage > (MODULE_STATE_GOING) the init section is empty, and this is clearer. > > Cc: Peter Oberparleiter <oberpar@linux.vnet.ibm.com> > Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> > --- > kernel/gcov/base.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/kernel/gcov/base.c b/kernel/gcov/base.c > index 7080ae1eb6c1..2f9df37940a0 100644 > --- a/kernel/gcov/base.c > +++ b/kernel/gcov/base.c > @@ -123,11 +123,6 @@ void gcov_enable_events(void) > } > > #ifdef CONFIG_MODULES > -static inline int within(void *addr, void *start, unsigned long size) > -{ > - return ((addr >= start) && (addr < start + size)); > -} > - > /* Update list and generate events when modules are unloaded. */ > static int gcov_module_notifier(struct notifier_block *nb, unsigned long event, > void *data) > @@ -142,7 +137,7 @@ static int gcov_module_notifier(struct notifier_block *nb, unsigned long event, > > /* Remove entries located in module from linked list. */ > while ((info = gcov_info_next(info))) { > - if (within(info, mod->module_core, mod->core_size)) { > + if (within_module((unsigned long)info, mod)) { > gcov_info_unlink(prev, info); > if (gcov_events_enabled) > gcov_event(GCOV_REMOVE, info);
Reviewed-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
| |