Messages in this thread | ![/](/images/icornerl.gif) | | Date | Mon, 9 Nov 2015 15:47:20 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH] tpm: fix compat 'ppi' link handling in tpm_chip_register() |
| |
On Sun, Nov 08, 2015 at 09:51:07AM +0200, Jarkko Sakkinen wrote: > + if (rc && rc != -ENOENT) { > + tpm_chip_unregister(chip); > + return rc; > + } > + }
This is still goofy looking, the list_add_tail_rcu should be the last thing done and cannot fail. Just code this with the usual goto based unwind and goto to do tpm_dev_del_device for the above failure.
> + > return 0; > out_err: > tpm1_chip_unregister(chip);
Which avoids calling tpm1_chip_unregister and tpm_chip_unregister in the same function, which looks so wrong to a casual read..
Jason
| ![\](/images/icornerr.gif) |