Messages in this thread | | | Date | Mon, 9 Nov 2015 15:32:16 -0700 | From | Jason Gunthorpe <> | Subject | Re: [PATCH 03/10] sysfs: added __compat_only_sysfs_link_entry_to_kobj() |
| |
On Fri, Nov 06, 2015 at 04:23:56PM -0800, Jeremiah Mahler wrote: > On Fri, Oct 16, 2015 at 09:40:22PM +0300, Jarkko Sakkinen wrote: > > Added a new function __compat_only_sysfs_link_group_to_kobj() that adds > > a symlink from attribute or group to a kobject. This needed for > > maintaining backwards compatibility with PPI attributes in the TPM > > driver.
> One problem with this patch is that it adds a bunch of code but none of > it is used. So if there is a bug, git bisect will point to a later > patch instead of this one.
It is fairly standard practice to split cross-subsystem patches like this, it aids review. git bisect is not a perfect tool.
Jason
| |