Messages in this thread | | | Date | Mon, 9 Nov 2015 13:58:08 +0100 | Subject | Re: [PATCH 03/26] Input: synaptics-rmi4 - explicitly request polling when needed | From | Linus Walleij <> |
| |
On Fri, Nov 6, 2015 at 12:37 AM, Andrew Duggan <aduggan@synaptics.com> wrote:
> From: Benjamin Tissoires <benjamin.tissoires@redhat.com> > > Host Notify does not work with neither IRQ nor polling. Allow a RMI4 driver > to request or not polling depending on the attn_gpio. > > When neither the internal IRQ or polling systems are used, the > transport driver can call rmi_process_interrupt_requests() to > trigger a process of the alert. > > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com> > Tested-by: Andrew Duggan <aduggan@synaptics.com>
(...) > + } else if (pdata->attn_gpio == RMI_POLLING) { (...) > +#define RMI_POLLING -1
Aeuck ... this thing should be rewritten to use GPIO descriptors instead of this old number-based stuff.
I'll go in and see if I can take a stab at it.
Yours, Linus Walleij
| |