lkml.org 
[lkml]   [2015]   [Nov]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior
From
Date
On 11/09/2015 04:12 AM, Johannes Stezenbach wrote:
> On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote:
>> +void tty_ldisc_closing(struct tty_struct *tty)
>> +{
>> + struct tty_ldisc *ld = tty_ldisc_ref(tty);
>> +
>> + if (ld->ops->closing)
>> + ld->ops->closing(tty);
>> + if (ld)
>> + tty_ldisc_deref(ld);
>> +}
>
> That looks strange. Do you need to check ld _before_ dereferencing?

Yes. Thanks for noticing.

Regards,
Peter Hurley


\
 
 \ /
  Last update: 2015-11-09 13:01    [W:0.100 / U:0.408 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site