Messages in this thread | | | Subject | Re: [PATCH 3/4] tty: Abstract and encapsulate tty->closing behavior | From | Peter Hurley <> | Date | Mon, 9 Nov 2015 06:58:42 -0500 |
| |
On 11/09/2015 04:12 AM, Johannes Stezenbach wrote: > On Sun, Nov 08, 2015 at 05:02:52PM -0500, Peter Hurley wrote: >> +void tty_ldisc_closing(struct tty_struct *tty) >> +{ >> + struct tty_ldisc *ld = tty_ldisc_ref(tty); >> + >> + if (ld->ops->closing) >> + ld->ops->closing(tty); >> + if (ld) >> + tty_ldisc_deref(ld); >> +} > > That looks strange. Do you need to check ld _before_ dereferencing?
Yes. Thanks for noticing.
Regards, Peter Hurley
| |