lkml.org 
[lkml]   [2015]   [Nov]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V3 4/4] dma: add Qualcomm Technologies HIDMA channel driver
From
On Sun, Nov 8, 2015 at 11:51 PM, Sinan Kaya <okaya@codeaurora.org> wrote:
>
>
> On 11/8/2015 3:47 PM, Andy Shevchenko wrote:
>>>
>>> + trca_resource = platform_get_resource(pdev, IORESOURCE_MEM, 0);
>>> >+ if (!trca_resource) {
>>> >+ rc = -ENODEV;
>>> >+ goto bailout;
>>> >+ }
>>
>> Why did you ignore my comment about this block?
>> Remove that condition entirely.
>>
>>> >+
>>> >+ trca = devm_ioremap_resource(&pdev->dev, trca_resource);
>>> >+ if (IS_ERR(trca)) {
>>> >+ rc = -ENOMEM;
>>> >+ goto bailout;
>>> >+ }
>
>
> Sorry, I didn't quite get your comment. I thought you wanted to see
> platform_get_resource and devm_ioremap_resource together.
>
> Which one do you want me to remove?

At the end you would have something like

res = platform_get_resource();
addr = devm_ioremap_resources();
if (!addr) {

}

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2015-11-08 23:21    [W:0.080 / U:1.420 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site