Messages in this thread | | | Date | Sun, 8 Nov 2015 23:23:38 +0200 | Subject | Re: [PATCH] mtd: phram: error handling | From | Andy Shevchenko <> |
| |
On Sun, Nov 8, 2015 at 10:47 AM, Saurabh Sengar <saurabh.truth@gmail.com> wrote: > registering the device with NULL pointer can lead to crash, > hence fixing it.
Hmm… Why not just checking it before an register attempt? I think user is in right to know as many problems as they have at one shot, with your patch if there are two problems the user has to try twice.
> > Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> > --- > in case of 'illegal start address' or 'illegal device length', name pointer is getting freed. > we shouldn't register the device with NULL pointer. > > drivers/mtd/devices/phram.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/mtd/devices/phram.c b/drivers/mtd/devices/phram.c > index 8b66e52..9a7aed3 100644 > --- a/drivers/mtd/devices/phram.c > +++ b/drivers/mtd/devices/phram.c > @@ -249,12 +249,14 @@ static int phram_setup(const char *val) > if (ret) { > kfree(name); > parse_err("illegal start address\n"); > + goto err; > } > > ret = parse_num64(&len, token[2]); > if (ret) { > kfree(name); > parse_err("illegal device length\n"); > + goto err; > } > > ret = register_device(name, start, len); > @@ -262,7 +264,7 @@ static int phram_setup(const char *val) > pr_info("%s device: %#llx at %#llx\n", name, len, start); > else > kfree(name); > - > +err: > return ret; > } > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/
-- With Best Regards, Andy Shevchenko
| |