Messages in this thread | | | Date | Fri, 6 Nov 2015 15:39:26 -0800 | From | Maxime Ripard <> | Subject | Re: [PATCH 01/19] clk: sunxi: Add display clock |
| |
Hi Stephen,
Thanks for your feedback!
On Fri, Oct 30, 2015 at 02:29:02PM -0700, Stephen Boyd wrote: > > + > > + mux = kzalloc(sizeof(*mux), GFP_KERNEL); > > + if (!mux) > [..] > > + goto free_reset; > > + } > > + > > + return; > > + > > +free_reset: > > + kfree(reset_data); > > +free_clk: > > + clk_unregister(clk); > > We really ought to have a clk_composite_unregister() API.
Can we?
We can always unregister the clock itself, but do we have a way to retrieve the structure that has been allocated in there?
(note that it also applies to the generic clocks registration: muxes, dividers, and so on).
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |