lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] iommu/arm-smmu: Delete an unnecessary check before free_io_pgtable_ops()
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Fri, 6 Nov 2015 18:32:41 +0100

    The free_io_pgtable_ops() function tests whether its argument is NULL
    and then returns immediately. Thus the test around the call is not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/iommu/arm-smmu.c | 4 +---
    1 file changed, 1 insertion(+), 3 deletions(-)

    diff --git a/drivers/iommu/arm-smmu.c b/drivers/iommu/arm-smmu.c
    index 47dc7a7..1ce4b85 100644
    --- a/drivers/iommu/arm-smmu.c
    +++ b/drivers/iommu/arm-smmu.c
    @@ -945,9 +945,7 @@ static void arm_smmu_destroy_domain_context(struct iommu_domain *domain)
    free_irq(irq, domain);
    }

    - if (smmu_domain->pgtbl_ops)
    - free_io_pgtable_ops(smmu_domain->pgtbl_ops);
    -
    + free_io_pgtable_ops(smmu_domain->pgtbl_ops);
    __arm_smmu_free_bitmap(smmu->context_map, cfg->cbndx);
    }

    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-06 19:01    [W:5.200 / U:0.032 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site