Messages in this thread | | | Date | Fri, 6 Nov 2015 15:32:29 +0100 | From | Oleg Nesterov <> | Subject | Re: [PATCH 0/3] signal: kill the obsolete SIGNAL_UNKILLABLE check in complete_signal() |
| |
On 11/05, Andrew Morton wrote: > > On Thu, 5 Nov 2015 21:17:20 +0100 Oleg Nesterov <oleg@redhat.com> wrote: > > > On 11/05, Oleg Nesterov wrote: > > > > > > Cough... and on the second thought this patch needs v2. Sorry Andrew, please > > > drop signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch > > > I'll send the updated version. > > > > > > With this patch the parent namespace can use any fatal signal (not only SIGKILL) > > > to kill the init process in container. I do not think this is actually bad, but > > > in any case this should not silently come as a side effect. And this is not > > > consistent with SIGNAL_UNKILLABLE/sig_kernel_only() check in get_signal(). > > > > > > Most probably I will just resend this patch as 2/2, while 1/2 will change > > > sig_task_ignored() because afaics it is not actually right too (albeit not > > > really buggy). > > > > So this replaces > > signal-kill-the-obsolete-signal_unkillable-check-in-complete_signal.patch > > 2/3 is actually the same change, just the changelog was updated. > > It's awfully late. Do you see any reason why we should jam this into 4.4?
No, I think this can wait till 4.5.
Oleg.
| |