lkml.org 
[lkml]   [2015]   [Nov]   [6]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC 3/3] ARM: e3xx: Add header file for pinctrl constants
Date
On Thursday 05 November 2015 15:41:23 Moritz Fischer wrote:
> +/* Pin names for the E31x usecase */
> +#define E31X_TX_BANDSEL_2 "DB_1"
> +#define E31X_RX1B_BANDSEL_0 "DB_3"
> +#define E31X_RX1B_BANDSEL_1 "DB_5"
> +#define E31X_VCTXRX2_V2 "DB_7"
> +#define E31X_TX_ENABLE1A "DB_9"
> +#define E31X_TX_ENABLE2A "DB_11"
> +#define E31X_TX_BANDSEL_0 "DB_12"

Why not put the strings directly into the .dts files and change the
lookup table in the driver accordingly:

+static const struct pinctrl_pin_desc e3xx_pins[] = {
+ /* pin0 doesn't exist */
+ PINCTRL_PIN(1, "TX_BANDSEL_2"),
+ PINCTRL_PIN(3, "RX1B_BANDSEL_0"),
+ PINCTRL_PIN(5, "RX1B_BANDSEL_1"),
+ PINCTRL_PIN(7, "VCTXRX2_V2"),

That would save you the hassle of the three-way dependency between the
dts file, the driver and the header when you want to change something
going through three different maintainer trees.

arnd


\
 
 \ /
  Last update: 2015-11-06 10:21    [W:1.740 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site