Messages in this thread | | | Date | Thu, 5 Nov 2015 14:58:56 +0000 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] ASoC: da7218: Add bindings documentation for DA7218 audio codec |
| |
On Thu, Nov 05, 2015 at 10:43:15AM +0000, Adam Thomson wrote:
> +- dlg,ldo-lvl : Required internal LDO voltage (mV) level > + [<1050>, <1100>, <1200>, <1400>]
Why would this ever be anything other than the minimum voltage, and might we not want to vary it at runtime?
> +- dlg,biquad-cfg : List of data & address pairs to configure BiQuad filters > + [ < {data1} {addr1} {data2} {addr2} ... >; ] > +- dlg,st-biquad-cfg : List of data & address pairs to configure Sidetone > + BiQuad filters > + [ < {data1} {addr1} {data2} {addr2} ... >; ]
These look like DSP coefficients which I would therefore expect to be configurable at runtime via a binary control rather than specified in the DT - why are they in the DT? [unhandled content-type:application/pgp-signature] | |