lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] staging/rdma/hfi1: Delete unnecessary checks before two function calls
    On Thu, Nov 05, 2015 at 09:10:47AM +0100, SF Markus Elfring wrote:
    > diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c
    > index aae9826..204d1d0 100644
    > --- a/drivers/staging/rdma/hfi1/file_ops.c
    > +++ b/drivers/staging/rdma/hfi1/file_ops.c
    > @@ -313,7 +313,7 @@ static ssize_t hfi1_file_write(struct file *fp, const char __user *data,
    > case HFI1_CMD_SDMA_STATUS_UPD:
    > break;
    > case HFI1_CMD_CREDIT_UPD:
    > - if (uctxt && uctxt->sc)
    > + if (uctxt)
    > sc_return_credits(uctxt->sc);

    Relying on hidden sanity checks makes the code harder to read.

    regards,
    dan carpenter



    \
     
     \ /
      Last update: 2015-11-05 09:41    [W:4.752 / U:0.000 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site