lkml.org 
[lkml]   [2015]   [Nov]   [5]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Subject[PATCH] staging/rdma/hfi1: Delete unnecessary checks before two function calls
    From
    Date
    From: Markus Elfring <elfring@users.sourceforge.net>
    Date: Thu, 5 Nov 2015 08:41:00 +0100

    The functions "sc_return_credits" and "vfree" perform also input
    parameter validation. Thus the tests around their calls are not needed.

    This issue was detected by using the Coccinelle software.

    Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
    ---
    drivers/staging/rdma/hfi1/file_ops.c | 2 +-
    drivers/staging/rdma/hfi1/user_sdma.c | 3 +--
    2 files changed, 2 insertions(+), 3 deletions(-)

    diff --git a/drivers/staging/rdma/hfi1/file_ops.c b/drivers/staging/rdma/hfi1/file_ops.c
    index aae9826..204d1d0 100644
    --- a/drivers/staging/rdma/hfi1/file_ops.c
    +++ b/drivers/staging/rdma/hfi1/file_ops.c
    @@ -313,7 +313,7 @@ static ssize_t hfi1_file_write(struct file *fp, const char __user *data,
    case HFI1_CMD_SDMA_STATUS_UPD:
    break;
    case HFI1_CMD_CREDIT_UPD:
    - if (uctxt && uctxt->sc)
    + if (uctxt)
    sc_return_credits(uctxt->sc);
    break;
    case HFI1_CMD_TID_UPDATE:
    diff --git a/drivers/staging/rdma/hfi1/user_sdma.c b/drivers/staging/rdma/hfi1/user_sdma.c
    index 36c838d..45f3797 100644
    --- a/drivers/staging/rdma/hfi1/user_sdma.c
    +++ b/drivers/staging/rdma/hfi1/user_sdma.c
    @@ -473,8 +473,7 @@ int hfi1_user_sdma_free_queues(struct hfi1_filedata *fd)
    fd->pq = NULL;
    }
    if (fd->cq) {
    - if (fd->cq->comps)
    - vfree(fd->cq->comps);
    + vfree(fd->cq->comps);
    kfree(fd->cq);
    fd->cq = NULL;
    }
    --
    2.6.2


    \
     
     \ /
      Last update: 2015-11-05 09:41    [W:2.906 / U:0.164 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site