Messages in this thread | | | Date | Wed, 4 Nov 2015 10:04:26 +0100 | Subject | Re: [PATCH] mtd: Make MTD_BCM47XXSFLASH to depend on MIPS | From | Rafał Miłecki <> |
| |
On 14 October 2015 at 11:04, Javier Martinez Canillas <javier@osg.samsung.com> wrote: > The bcm47xxsflash driver uses the KSEG0ADDR() function to map an address > to a certain kernel segment. But that is only defined if the MIPS config > symbol is enabled. The driver does not have an explicit dependency on it > and relies on a transitive dependency relation: > > MTD_BCM47XXSFLASH -> BCMA_SFLASH -> BCMA_DRIVER_MIPS -> BCMA && MIPS > > But BCMA_SFLASH and BCMA_DRIVER_MIPS have only runtime and not buildtime > dependency with MIPS so can be changed to be built test using the config > COMPILE_TEST symbol. But that would make MTD_BCM47XXSFLASH be built with > MIPS not enabled and cause the following build error: > > drivers/mtd/devices//bcm47xxsflash.c: In function 'bcm47xxsflash_read': > drivers/mtd/devices//bcm47xxsflash.c:112:2: error: implicit declaration of function 'KSEG0ADDR' [-Werror=implicit-function-declaration] > memcpy_fromio(buf, (void __iomem *)KSEG0ADDR(b47s->window + from),
I think we're not really supposed to use KSEG0ADDR anyway. What about replacing it with ioremap_nocache?
Sorry for the late reply.
| |