Messages in this thread Patch in this message | | | Subject | [PATCH] GFS2: Delete an unnecessary check before the function call "iput" | From | SF Markus Elfring <> | Date | Wed, 4 Nov 2015 21:27:14 +0100 |
| |
From: Markus Elfring <elfring@users.sourceforge.net> Date: Wed, 4 Nov 2015 21:23:43 +0100
The iput() function tests whether its argument is NULL and then returns immediately. Thus the test around the call is not needed.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net> --- fs/gfs2/ops_fstype.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c index baab99b..1f9de17 100644 --- a/fs/gfs2/ops_fstype.c +++ b/fs/gfs2/ops_fstype.c @@ -910,8 +910,7 @@ fail_qc_i: fail_ut_i: iput(sdp->sd_sc_inode); fail: - if (pn) - iput(pn); + iput(pn); return error; } -- 2.6.2
| |