lkml.org 
[lkml]   [2015]   [Nov]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCHv2 2/4] arm-cci: Get the status of a counter
    From
    Date
    On 04/11/15 18:06, Mark Rutland wrote:
    > On Tue, Oct 20, 2015 at 02:05:24PM +0100, Suzuki K. Poulose wrote:
    >> Add helper routines to get the counter status and the event
    >> programmed on it.
    >>

    >> +static u32 pmu_get_counter_ctrl(struct cci_pmu *cci_pmu, int idx)
    >> +{
    >> + return pmu_read_register(cci_pmu, idx, CCI_PMU_CNTR_CTRL) & 0x1;
    >> +}
    >
    > Given the function is called pmu_get_counter_ctrl, why the '& 1'?

    Thats because the Count Control has only 1 bit defined. The rest is RES0.

    >
    > Either this should return the raw value, or the function should be
    > renamed to something like pmu_counter_is_enabled, and made bool.

    Makes sense. I will change it to pmu_counter_is_enabled().

    Thanks
    Suzuki



    \
     
     \ /
      Last update: 2015-11-04 19:41    [W:5.570 / U:0.076 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site