Messages in this thread | | | Date | Mon, 30 Nov 2015 17:10:07 -0800 | Subject | Re: [PATCHv2] arm: Update all mm structures with section adjustments | From | Kees Cook <> |
| |
On Mon, Nov 30, 2015 at 4:42 PM, Laura Abbott <labbott@redhat.com> wrote: > On 11/30/2015 03:40 PM, Kees Cook wrote: >> >> On Thu, Nov 19, 2015 at 11:10 AM, Kees Cook <keescook@chromium.org> wrote: >>> >>> On Wed, Nov 18, 2015 at 4:14 PM, Laura Abbott <labbott@fedoraproject.org> >>> wrote: >>>> >>>> Currently, when updating section permissions to mark areas RO >>>> or NX, the only mm updated is current->mm. This is working off >>>> the assumption that there are no additional mm structures at >>>> the time. This may not always hold true. (Example: calling >>>> modprobe early will trigger a fork/exec). Ensure all mm structres >>>> get updated with the new section information. >>>> >>>> Signed-off-by: Laura Abbott <labbott@fedoraproject.org> >>> >>> >>> This looks right to me. :) >>> >>> Reviewed-by: Kees Cook <keescook@chromium.org> >>> >>> Russell, does this work for you? >> >> >> Did this end up in the patch tracker? (I just sent a patch that'll >> collide with this... I'm happy to do the fix up.) >> > > I put this in the patch tracker this morning.
Ah-ha, great! I will rebase my change on to it and send a v2 (potentially with additional changes).
-Kees
> >> >> -Kees >> > > Thanks, > Laura
-- Kees Cook Chrome OS & Brillo Security
| |