Messages in this thread | | | Date | Tue, 1 Dec 2015 01:43:12 +0100 | From | Wolfram Sang <> | Subject | Re: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller |
| |
> > > > The driver disables TX interrupt when it is not needed anymore or > > > > when TX gets aborted but the above will re-enable all interrupts > > regardless. > > > > Is that the intention? > > > No, i2c controller can trigger next interrupt only after re-enable all interrupt. > > > > If you get an error the function masks all interrupts and jumps to tx_aborted > > label. With this patch you unmask all interrupts again before exiting the > > function. > > > > I see, how about change if statement to else if?
That sounds to me that a V2 is needed, or? Marking as "Changes requested"...
[unhandled content-type:application/pgp-signature]
| |