lkml.org 
[lkml]   [2015]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/1] I2C: designware: fix IO timeout issue for AMD controller

> > > > The driver disables TX interrupt when it is not needed anymore or
> > > > when TX gets aborted but the above will re-enable all interrupts
> > regardless.
> > > > Is that the intention?
> > > No, i2c controller can trigger next interrupt only after re-enable all interrupt.
> >
> > If you get an error the function masks all interrupts and jumps to tx_aborted
> > label. With this patch you unmask all interrupts again before exiting the
> > function.
> >
>
> I see, how about change if statement to else if?

That sounds to me that a V2 is needed, or? Marking as "Changes
requested"...

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2015-12-01 02:01    [W:0.118 / U:2.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site