lkml.org 
[lkml]   [2015]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V5 net-next 1/5] net:hns: Add support of Hip06 SoC to the Hislicon Network Subsystem
From
From: Salil Mehta <salil.mehta@huawei.com>
Date: Thu, 26 Nov 2015 07:14:06 +0000

> -#define ENABLE (0x1)
> -#define DISABLE (0x0)
> +#define ENABLE 0x1
> +#define DISABLE 0x0

Defining such common macros names for such incredibly simple boolean values
is asking for trouble, in particular it can possibly collide with other
defines in the global namespace.

Use "true", "false", and the "bool" type, because that is exactly how you
are using these values.

Thanks.




\
 
 \ /
  Last update: 2015-11-30 21:01    [W:0.075 / U:0.064 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site