lkml.org 
[lkml]   [2015]   [Nov]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] spi/nor: Fix error message with unrecognized JEDEC
Date
On Monday, November 30, 2015 at 04:25:11 PM, Ricardo Ribalda Delgado wrote:
> The error message was:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 0, 0
>
> The new error message:
>
> m25p80 spi32766.0: unrecognized JEDEC id bytes: 00, 00, 00
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
> drivers/mtd/spi-nor/spi-nor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c
> index b7c038c75684..7d2b96d5f350 100644
> --- a/drivers/mtd/spi-nor/spi-nor.c
> +++ b/drivers/mtd/spi-nor/spi-nor.c
> @@ -890,7 +890,7 @@ static const struct flash_info *spi_nor_read_id(struct
> spi_nor *nor) return &spi_nor_ids[tmp];
> }
> }
> - dev_err(nor->dev, "unrecognized JEDEC id bytes: %02x, %2x, %2x\n",
> + dev_err(nor->dev, "unrecognized JEDEC id bytes: %.2x, %.2x, %.2x\n",

You can change it to %02x to make it consistent, no ? What do you think ?

> id[0], id[1], id[2]);
> return ERR_PTR(-ENODEV);
> }

Best regards,
Marek Vasut


\
 
 \ /
  Last update: 2015-11-30 18:01    [W:0.036 / U:0.284 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site