Messages in this thread | | | Date | Mon, 30 Nov 2015 16:55:35 +0100 | Subject | Re: [PATCH v2 3/9] includes: dt-bindings: Add STM32F429 pinctrl DT bindings | From | Maxime Coquelin <> |
| |
2015-11-17 12:00 GMT+01:00 Linus Walleij <linus.walleij@linaro.org>: > On Fri, Nov 6, 2015 at 1:57 PM, Maxime Coquelin > <mcoquelin.stm32@gmail.com> wrote: > >> Thinking again at it, I persist to believe have the defines makes it >> easier to use. >> With auto-completion, it makes it faster and less error prone to >> select the right >> alternate function without parsing the datasheet. > > Auto-completion ... should we design our source code to > fit certain editors? No, you are right. But even without auto-completion, it is easier to have the values pre-computed. And Mediatek has the defines, so it is better to do the same for STM32 for consistency.
>> But as these defines are not actually used on driver side, maybe I >> could just move >> them to the dts directory? > > No strong opinion there. include/dt-bindings is part of the bindings > documentation actually so I guess it goes there. Ok.
Thanks, Maxime
| |