Messages in this thread | | | Date | Mon, 30 Nov 2015 11:05:10 +0200 | From | Mathias Nyman <> | Subject | Re: [PATCH] usb: host: pci_quirks: fix memory leak, by adding iounmap |
| |
On 30.11.2015 08:28, Saurabh Sengar wrote: > pinging in case this patch is lost. > > > On 6 November 2015 at 17:46, Saurabh Sengar <saurabh.truth@gmail.com> wrote: >> added iounmap inorder to free memory mapped to base before returning >> >> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com> >> --- >> drivers/usb/host/pci-quirks.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/pci-quirks.c b/drivers/usb/host/pci-quirks.c >> index f940056..332f687 100644 >> --- a/drivers/usb/host/pci-quirks.c >> +++ b/drivers/usb/host/pci-quirks.c >> @@ -990,7 +990,7 @@ static void quirk_usb_handoff_xhci(struct pci_dev *pdev) >> /* We're reading garbage from the controller */ >> dev_warn(&pdev->dev, >> "xHCI controller failing to respond"); >> - return; >> + goto iounmap; >> } >> >> if (!ext_cap_offset) >> @@ -1061,7 +1061,7 @@ hc_init: >> "xHCI HW did not halt within %d usec status = 0x%x\n", >> XHCI_MAX_HALT_USEC, val); >> } >> - >> +iounmap: >> iounmap(base); >> } >> >> -- >> 1.9.1 >>
Thanks, I'll add it send it forward soon
-Mathias
| |