Messages in this thread | | | From | Kalle Valo <> | Subject | Re: [PATCH v2] ath6kl: Use vmalloc for loading firmware using api1 method and use kvfree | Date | Mon, 30 Nov 2015 10:48:03 +0200 |
| |
Brent Taylor <motobud@gmail.com> writes:
> Signed-off-by: Brent Taylor <motobud@gmail.com> > > ath6kl: Use vmalloc for loading firmware using api1 method and free using kvfree > --- > Changes v1 -> v2: > - simplify memory allocation > - use kvfree
Why? The commit log should _always_ answer that. Are you fixing a bug (what bug exactly?), is this just cleanup or what?
And the commit log is wrongly formatted anyway, the Signed-off-by line should be the last and there should be no "ath6kl:" string in the commit log (just in the title). Use 'git log' to find examples.
-- Kalle Valo
| |