lkml.org 
[lkml]   [2015]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH v1 02/20] clocksource: Add NPS400 timers driver
    Date
    From: Vineet Gupta [mailto:Vineet.Gupta1@synopsys.com] 
    Sent: Monday, November 02, 2015 1:04 PM

    >> +
    >> + upper = ioread32be(upper_p);

    >Consider using the _relaxed macros even if your platform doesn't have specific IO barriers.
    [Noam Camus] What is the big endian flavor for _relaxed macros.

    >> + counter = upper;
    >> + counter <<= 32;
    >> + counter |= lower;

    >It is easier to read:

    >counter = (upper << 32) | lower;

    Thanks I will update

    - Noam



    \
     
     \ /
      Last update: 2015-11-03 17:21    [W:4.327 / U:0.040 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site