lkml.org 
[lkml]   [2015]   [Nov]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH RESEND 00/16] Support TI LMU devices
From
Date
Hi Lee,

On 11/2/2015 5:59 PM, Lee Jones wrote:
>> drivers/video/backlight/Kconfig | 62 ++
>> > drivers/video/backlight/Makefile | 7 +
>> > drivers/video/backlight/lm3532_bl.c | 183 +++++
>> > drivers/video/backlight/lm3631_bl.c | 129 ++++
>> > drivers/video/backlight/lm3632_bl.c | 125 ++++
>> > drivers/video/backlight/lm3633_bl.c | 210 ++++++
>> > drivers/video/backlight/lm3695_bl.c | 91 +++
>> > drivers/video/backlight/lm3697_bl.c | 187 +++++
>> > drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++
>> > drivers/video/backlight/ti-lmu-backlight.h | 152 +++++
> How different are all of these drivers?
>
> Can you create one driver that supports them all instead?
>

Thanks for your suggestion.

'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each
lmxxx_bl has its own operation functions by using ti_lmu_bl_ops.
I've tried to make consolidated driver but it contained too much device
specific code in one file. So I prefer simple drivers structure -
'common part' and 'device specific operations'.
It would be appreciated if you could introduce better idea.

Best regards,
Milo


\
 
 \ /
  Last update: 2015-11-03 08:01    [W:0.777 / U:0.040 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site