Messages in this thread | | | Subject | Re: [PATCH RESEND 00/16] Support TI LMU devices | From | "Kim, Milo" <> | Date | Tue, 3 Nov 2015 15:52:08 +0900 |
| |
Hi Lee,
On 11/2/2015 5:59 PM, Lee Jones wrote: >> drivers/video/backlight/Kconfig | 62 ++ >> > drivers/video/backlight/Makefile | 7 + >> > drivers/video/backlight/lm3532_bl.c | 183 +++++ >> > drivers/video/backlight/lm3631_bl.c | 129 ++++ >> > drivers/video/backlight/lm3632_bl.c | 125 ++++ >> > drivers/video/backlight/lm3633_bl.c | 210 ++++++ >> > drivers/video/backlight/lm3695_bl.c | 91 +++ >> > drivers/video/backlight/lm3697_bl.c | 187 +++++ >> > drivers/video/backlight/ti-lmu-backlight.c | 429 ++++++++++++ >> > drivers/video/backlight/ti-lmu-backlight.h | 152 +++++ > How different are all of these drivers? > > Can you create one driver that supports them all instead? >
Thanks for your suggestion.
'ti-lmu-backlight' is the common part of lmxxxx_bl drivers. And each lmxxx_bl has its own operation functions by using ti_lmu_bl_ops. I've tried to make consolidated driver but it contained too much device specific code in one file. So I prefer simple drivers structure - 'common part' and 'device specific operations'. It would be appreciated if you could introduce better idea.
Best regards, Milo
| |