Messages in this thread | | | From | "Grumbach, Emmanuel" <> | Subject | Re: [PATCH] iwlwifi: fix compare_const_fl.cocci warnings | Date | Sat, 28 Nov 2015 18:46:09 +0000 |
| |
Hi Julia,
On 11/27/2015 06:11 PM, Julia Lawall wrote: > Move constants to the right of binary operators. > > Generated by: scripts/coccinelle/misc/compare_const_fl.cocci > > Signed-off-by: Fengguang Wu <fengguang.wu@intel.com> > Signed-off-by: Julia Lawall <julia.lawall@lip6.fr> > --- > > This looks a bit nicer around the other way, in my opinion.
Thanks, I picked it up. I agree with your taste although having constants on the left side can avoid the typo = instead of == since they can't be an l-value. Obviously we never do that and prefer to have the constant on the right side. More readable for sure. > > calib.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > --- a/drivers/net/wireless/intel/iwlwifi/dvm/calib.c > +++ b/drivers/net/wireless/intel/iwlwifi/dvm/calib.c > @@ -311,7 +311,7 @@ static int iwl_sens_energy_cck(struct iw > /* If previous beacon had too many false alarms, > * give it some extra margin by reducing sensitivity again > * (but don't go below measured energy of desired Rx) */ > - if (IWL_FA_TOO_MANY == data->nrg_prev_state) { > + if (data->nrg_prev_state == IWL_FA_TOO_MANY) { > IWL_DEBUG_CALIB(priv, "... increasing margin\n"); > if (data->nrg_th_cck > (max_nrg_cck + NRG_MARGIN)) > data->nrg_th_cck -= NRG_MARGIN; >
| |