Messages in this thread Patch in this message | ![/](/images/icornerl.gif) | | From | Peter Hurley <> | Subject | [PATCH v2 3/3] n_tty: Reduce branching in canon_copy_from_read_buf() | Date | Fri, 27 Nov 2015 14:11:04 -0500 |
| |
Instead of compare-and-set, just compute 'found'.
Signed-off-by: Peter Hurley <peter@hurleysoftware.com> --- drivers/tty/n_tty.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/tty/n_tty.c b/drivers/tty/n_tty.c index eab606a..9b0b610 100644 --- a/drivers/tty/n_tty.c +++ b/drivers/tty/n_tty.c @@ -2079,10 +2079,9 @@ static int canon_copy_from_read_buf(struct tty_struct *tty, if (eol == N_TTY_BUF_SIZE && more) { /* scan wrapped without finding set bit */ eol = find_next_bit(ldata->read_flags, more, 0); - if (eol != more) - found = 1; - } else if (eol != size) - found = 1; + found = eol != more; + } else + found = eol != size; n = eol - tail; if (n > N_TTY_BUF_SIZE) -- 2.6.3
| ![\](/images/icornerr.gif) |