lkml.org 
[lkml]   [2015]   [Nov]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v2 1/1] platform: goldfish: pipe: add devicetree bindings
From
Date
On 11/26/15 12:34 AM, Christoffer Dall wrote:
> On Wed, Nov 25, 2015 at 02:24:16PM -0600, Rob Herring wrote:
>>
>> The binding may be trivial, but there's a bigger question of whether
>> this is the right long term direction. For example is upstream QEMU
>> going to take all the Android pipe stuff? Couldn't virtio be used here
>> as the transport?
>>
>
> But I wonder if that should really block this from being merged? The
> support may not be in QEMU but it's in the Android emulator and it would
> be a less broken implementation with these patches in the kernel than
> without, I think.
>
> -Christoffer
>

To add to Christoffer's point, we added these bindings so we don't need
to rely on the goldfish virtual bus for probing anymore.

Switching from the goldfish virtual bus to Device-Tree already
eliminates one big piece where the Android emulator has diverged from
upstream qemu. And on the kernel side, it means we don't need ARM and
MIPS goldfish board code to instantiate the bus.

In the long term I'm happy to push the SDK team towards replacing the
Android pipe with a virtio alternative. (We've already been switching
over to virtio for things like storage.) But in the short term, we
still need it. And I don't think it benefits the mainline kernel if we
have to maintain cleanup patches like this out-of-tree.



\
 
 \ /
  Last update: 2015-11-27 19:41    [W:3.279 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site