Messages in this thread Patch in this message | | | Date | Fri, 27 Nov 2015 13:17:40 -0300 | From | Arnaldo Carvalho de Melo <> | Subject | Re: perf test unwind failing |
| |
Em Fri, Nov 27, 2015 at 01:03:11PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Fri, Nov 27, 2015 at 09:21:21AM +0100, Jiri Olsa escreveu: > > On Thu, Nov 26, 2015 at 05:45:59PM -0300, Arnaldo Carvalho de Melo wrote: > > > Can you take a look at 'perf test unwind'? It is failing in my > > > perf/core branch, no time to bisect that now. > See above. > > After reading the patch I see why you refer to that patch, it is just > that at machine__exit() one should free the kernel maps if they were > created, so it calls machine__destroy_kernel_maps(), and that will check > if the maps were allocated, if not, nothing will be done. > > Anyway, I applied your patch, it fixes the problem, thanks!
Applied this one to my local tree:
From 9bdcede563a831f139b5fc872f028ef844a7462e Mon Sep 17 00:00:00 2001 From: Jiri Olsa <jolsa@redhat.com> Date: Fri, 27 Nov 2015 09:21:21 +0100 Subject: [PATCH 1/1] perf test: 'unwind' test should create kernel maps
The 'perf test unwind' is failing because it forgot to create the kernel maps, fix it.
After the patch:
# perf test unwind 40: Test dwarf unwind : Ok
Reported-and-Tested-by: Arnaldo Carvalho de Melo <acme@redhat.com> Signed-off-by: Jiri Olsa <jolsa@redhat.com> Cc: David Ahern <dsahern@gmail.com> Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com> Cc: Namhyung Kim <namhyung@kernel.org> Link: http://lkml.kernel.org/r/20151127082121.GA24503@krava.brq.redhat.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/tests/dwarf-unwind.c | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/tools/perf/tests/dwarf-unwind.c b/tools/perf/tests/dwarf-unwind.c index b2357e8115a2..3cce13b19cbb 100644 --- a/tools/perf/tests/dwarf-unwind.c +++ b/tools/perf/tests/dwarf-unwind.c @@ -173,6 +173,11 @@ int test__dwarf_unwind(int subtest __maybe_unused) return -1; } + if (machine__create_kernel_maps(machine)) { + pr_err("Failed to create kernel maps\n"); + return -1; + } + callchain_param.record_mode = CALLCHAIN_DWARF; if (init_live_machine(machine)) { -- 2.1.0
| |