Messages in this thread Patch in this message | | | Subject | Re: [PATCH v2 7/9] mm, page_owner: dump page owner info from dump_page() | From | Vlastimil Babka <> | Date | Thu, 26 Nov 2015 11:43:57 +0100 |
| |
On 11/25/2015 03:58 PM, Michal Hocko wrote: > Nice! This can be really helpful. > >> Signed-off-by: Vlastimil Babka <vbabka@suse.cz> > > Appart from a typo below, looks good to me > Acked-by: Michal Hocko <mhocko@suse.com>
Thanks!
> [...] > >> +void __dump_page_owner(struct page *page) >> +{ >> + struct page_ext *page_ext = lookup_page_ext(page); >> + struct stack_trace trace = { >> + .nr_entries = page_ext->nr_entries, >> + .entries = &page_ext->trace_entries[0], >> + }; >> + gfp_t gfp_mask = page_ext->gfp_mask; >> + int mt = gfpflags_to_migratetype(gfp_mask); >> + >> + if (!test_bit(PAGE_EXT_OWNER, &page_ext->flags)) { >> + pr_alert("page_owner info is not active (free page?)\n"); >> + return; >> + } >> + ; > > Typo?
The cat did it!
------8<------ From: Vlastimil Babka <vbabka@suse.cz> Date: Thu, 26 Nov 2015 11:41:11 +0100 Subject: mm, page_owner: dump page owner info from dump_page()-fix
Remove stray semicolon. --- mm/page_owner.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/page_owner.c b/mm/page_owner.c index a81cfa0c13c3..f4acd2452c35 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -207,7 +207,7 @@ void __dump_page_owner(struct page *page) pr_alert("page_owner info is not active (free page?)\n"); return; } - ; + pr_alert("page allocated via order %u, migratetype %s, gfp_mask 0x%x", page_ext->order, migratetype_names[mt], gfp_mask); dump_gfpflag_names(gfp_mask); -- 2.6.3
| |