lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] ASoC: rockchip: Fix incorrect VDW value for 24 bit
From
Date
Hi,

在 2015年11月25日 16:54, Sjoerd Simons 写道:
> Correct valid data word register value for 24 bit data width. The
> bit value should be 10 (aka 0x2), not 0x10.
>
> This fixes playback of 24 bit audio.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> ---
>
> sound/soc/rockchip/rockchip_spdif.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/rockchip/rockchip_spdif.h b/sound/soc/rockchip/rockchip_spdif.h
> index 07f86a2..921b409 100644
> --- a/sound/soc/rockchip/rockchip_spdif.h
> +++ b/sound/soc/rockchip/rockchip_spdif.h
> @@ -28,9 +28,9 @@
> #define SPDIF_CFGR_VDW(x) (x << SPDIF_CFGR_VDW_SHIFT)
> #define SDPIF_CFGR_VDW_MASK (0xf << SPDIF_CFGR_VDW_SHIFT)
>
> -#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x00)
> -#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x01)
> -#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x10)
> +#define SPDIF_CFGR_VDW_16 SPDIF_CFGR_VDW(0x0)
> +#define SPDIF_CFGR_VDW_20 SPDIF_CFGR_VDW(0x1)
> +#define SPDIF_CFGR_VDW_24 SPDIF_CFGR_VDW(0x2)

Yep,
From the TRM says: (RK3288/RK3368...)

VDW
Valid data width
00: 16bit
01: 20bit
10: 24bit
11: reserved
....

So feel free add my tag:

Reviewed-by: Caesar Wang <wxt@rock-chips.com>


>
> /*
> * DMACR


--
caesar wang | software engineer | wxt@rock-chip.com




\
 
 \ /
  Last update: 2015-11-25 10:21    [W:0.031 / U:4.456 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site