Messages in this thread | | | Date | Wed, 25 Nov 2015 12:42:21 -0500 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/2] ftrace: Add separate handler for ftrace:function event |
| |
On Wed, 25 Nov 2015 18:12:43 +0100 Jiri Olsa <jolsa@redhat.com> wrote:
> > Yeah, I'm trying to figure out the paths here. I would love to remove > > the control_ops as that complicates the function tracing code a bit > > more than I would like it to be. > > perf is using the control interface to enable and disable function > tracing any time the process (and its events) is scheduled in/out > > sched_in(event) -> ftrace_function_local_enable(&event->ftrace_ops) > sched_out(event) -> ftrace_function_local_disable(&event->ftrace_ops)
OK, I think we can merge the control list to the normal list and have something like:
(!op->disabled || !ftrace_function_local_disabled(op))
We can also keep the control flag for the ops, and have:
!(op->flags & FTRACE_OPS_FL_CONTROL) || rcu_is_watching()
test too, and use the ftrace ops list code.
-- Steve
| |