lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] thermal: rcar: enable to set tripN-temp via DT
Date

Hi Eduardo

Thank you for your feedback

> > From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> >
> > Current rcar thermal driver is using 90 degrees as trip temp, but it
> > should be based on each SoC / platform.
> > This patch enables to set trip temp via DT. (It uses db8500-thermal
> > style for it)
> > It will use 90 degrees as default trip temp if DT doesn't have it.
> >
> > Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> > ---
> > .../devicetree/bindings/thermal/rcar-thermal.txt | 2 ++
> > drivers/thermal/rcar_thermal.c | 34 ++++++++++++++++++++--
> > 2 files changed, 33 insertions(+), 3 deletions(-)
> >
> > diff --git a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > index 332e625..6c57f7e 100644
> > --- a/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > +++ b/Documentation/devicetree/bindings/thermal/rcar-thermal.txt
> > @@ -18,6 +18,8 @@ Required properties:
> > Option properties:
> >
> > - interrupts : use interrupt
> > +- tripN-temp : temperature of trip point N. it will use 90000 as default
> > + if DT doesn't have tripN-temp
>
> First of all, you are creating an entry with is specific to your driver.
> That requires it to use proper prefixing.
>
> Besides, your property is already covered by of-thermal. Please convert
> your driver to use of-thermal, this way it will give you the flexibility
> to configure thermal data in DT.

I see, but we need to keep compatibility for non-DT SoC.
(This driver is used from both DT, non-DT SoC)

Then, I noticed we can use .set_trip_temp, and it is very enough for us.



\
 
 \ /
  Last update: 2015-11-25 06:41    [W:0.057 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site