lkml.org 
[lkml]   [2015]   [Nov]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    Date
    SubjectRe: [PATCH 2/7] drm/vmwgfx: fix a problematic usage of WARN_ON()
    Reviewed-by: Sinclair Yeh <syeh@vmware.com>

    On Wed, Nov 25, 2015 at 09:12:15PM +0800, Geliang Tang wrote:
    > WARN_ON() takes a condition rather than a format string. This patch
    > converted WARN_ON() to WARN() instead.
    >
    > Signed-off-by: Geliang Tang <geliangtang@163.com>
    > ---
    > drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
    > index a8baf5f..b6a0806 100644
    > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
    > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fifo.c
    > @@ -390,7 +390,7 @@ void *vmw_fifo_reserve_dx(struct vmw_private *dev_priv, uint32_t bytes,
    > else if (ctx_id == SVGA3D_INVALID_ID)
    > ret = vmw_local_fifo_reserve(dev_priv, bytes);
    > else {
    > - WARN_ON("Command buffer has not been allocated.\n");
    > + WARN(1, "Command buffer has not been allocated.\n");
    > ret = NULL;
    > }
    > if (IS_ERR_OR_NULL(ret)) {
    > --
    > 2.5.0
    >
    >


    \
     
     \ /
      Last update: 2015-11-25 17:21    [W:2.863 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site