Messages in this thread | | | From | 河合英宏 / KAWAI,HIDEHIRO <> | Subject | RE: [V5 PATCH 2/4] panic/x86: Allow cpus to save registers even if they are looping in NMI context | Date | Wed, 25 Nov 2015 15:11:05 +0000 |
| |
> On Wed, Nov 25, 2015 at 09:46:37AM +0000, 河合英宏 / KAWAI,HIDEHIRO wrote: ... > > I prefer this, but we might want to add some more prefix or suffix. > > For example, "conditionally_run_crash_nmi_callback". > > That's unnecessary IMO. If you need to express that, you could write > that in a comment above the function definition. Anyone who looks at > the code then will know that it is conditional, like so many other > kernel functions. :)
OK, I'll use a simple one with a comment.
Regards,
-- Hidehiro Kawai Hitachi, Ltd. Research & Development Group
| |